Repository navigation
gh-161366: Fix deadlock with FT GC debug collectables print - #161444
Merged
Merged
Conversation
debug printing collectables ran under stop the world in the debug cycle which can deadlock on buffered writer. In debug mode this immediately. We move the debug print to outside of stop the world block inside the `needs_resurrection_check` so the correct cleanup can run but before collection.
johng
commented
Nov 5, 2026
|
|
||
| self.assertTrue(C().run()) | ||
|
|
||
| def test_debug_collectable_python_stderr(self): |
Contributor
Author
There was a problem hiding this comment.
Unsure of precedence with this type of test, it will only be useful in debug mode
johng
commented
Nov 5, 2026
| _PyEval_StartTheWorld(interp); | ||
|
|
||
| // Print debugging information. | ||
| if (FT_ATOMIC_LOAD_INT_RELAXED(interp->gc.debug) & _PyGC_DEBUG_COLLECTABLE) { |
Contributor
Author
There was a problem hiding this comment.
we hit this code branch always when in debug collectables mode, however this section is after start the world
johng
marked this pull request as ready for review
November 5, 2026 21:15
Contributor
Author
|
CC @sergey-miryanov @nascheme thanks! |
kumaraditya303
changed the title
kumaraditya303
approved these changes
Nov 9, 2026
|
GH-162007 is a backport of this pull request to the 3.15 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debug printing collectables ran under stop the world in the debug cycle which can deadlock on buffered writer. In debug mode this immediately fails.
We move the debug print to outside of stop the world block inside the
needs_resurrection_checkso the correct cleanup can run before collection.